-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][amplitude] Upgrade Amplitude-iOS@4.7.1 to Amplitude@6.0.0 #9880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
Did you make sure we don't need to run pod install
in bare-expo
?
Could you please add a note about this upgrade to expo-analytics-amplitude
changelog?
@@ -6,6 +6,8 @@ | |||
|
|||
### 馃帀 New features | |||
|
|||
- Upgraded native Amplitude iOS library from `4.7.1` to `6.0.0`. ([#9880](https://github.com/expo/expo/pull/9880) by [@bbarthec](https://github.com/bbarthec)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think if we also mention about changes with IDFA
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
50/50 馃槈 I don't see a reason for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention it, I added a note about the same removal for the segment library, because this is a breaking change that users should know about. If they want want to collect the IDFA, they need to use the bare workflow now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! glad we are definitely going to be safe and avoid any potential app rejections because of this 馃槃
this upgrade also "Removed disableIdfaTracking
API." so I think we should remove that option here and also remove it from the docs.
@@ -6,6 +6,8 @@ | |||
|
|||
### 馃帀 New features | |||
|
|||
- Upgraded native Amplitude iOS library from `4.7.1` to `6.0.0`. ([#9880](https://github.com/expo/expo/pull/9880) by [@bbarthec](https://github.com/bbarthec)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention it, I added a note about the same removal for the segment library, because this is a breaking change that users should know about. If they want want to collect the IDFA, they need to use the bare workflow now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the missing breaking change log looks good to me! 馃憤
- Amplitude-iOS changed it's name to Amplitude - Amplitude v6.0.0 introduced accomodation for new rules over IDFA in iOS 14
989033f
to
ed3d8ba
Compare
# Why Amplitude-iOS changed it's name to Amplitude Amplitude v6.0.0 introduced accommodation for new rules over IDFA in iOS 14 # How Changed Amplitude-iOS ~> v4.7.1 to Amplitude ~> 6.0.0 across whole iOS project (versioned pods included).
Why
How
Amplitude-iOS ~> v4.7.1
toAmplitude ~> 6.0.0
across whole iOS project (versioned pods included).Test Plan
Home
that uses Amplitude works without crashes (home
is the only app that actually uses Amplitude package)expo-analytics-amplitude
after this upgrade 馃槄Changelog